Port: use consistent architecture identifier #865
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willieyz
force-pushed
the
consistent_arch_id
branch
from
e111144 to
f6e7b6f
Compare
willieyz
force-pushed
the
consistent_arch_id
branch
2 times, most recently
from
afdb0b5 to
e2cc3f2
Compare
mkannwischer
approved these changes
Jan 12, 2026
Contributor
mkannwischer
left a comment
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @willieyz. LGTM!
This commit ports the change from pq-code-package/mlkem-native#1456 to mldsa-native. Currently, mldsa-native already uses x86_64 as the architecture identifier for x86 in its existing HOL-Light proofs, and no changes are required in that regard. This commit simply aligns the surrounding scripts and infrastructure to consistently use x86_64 as the architecture name. - Adds the related scripts to support dual architectures by introducing an explicit arch parameter in the autogen process. - Replaces the arm_or_x86 flag with a unified arch flag in test scripts. Signed-off-by: willieyz <[email protected]>
mkannwischer
force-pushed
the
consistent_arch_id
branch
from
e2cc3f2 to
7344756
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
autogen#857Currently, mldsa-native already uses x86_64 as the architecture identifier for x86 in its existing HOL-Light proofs, and no changes are required in that regard. This commit simply aligns the surrounding scripts and infrastructure to consistently use x86_64 as the architecture name.
Adds the related scripts to support dual architectures by introducing an explicit arch parameter in the autogen process.
Replaces the arm_or_x86 flag with a unified arch flag in test scripts.